lbryio / lbryio/lbry-android

Linting errors hinder ability to build repository

Open
#1,064 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
2.4k
Forks
110
PR merge metrics
No merged PRs in 30d

Description

## The Issue
I keep getting linting errors when trying to build this app. I'm fairly sure it's not just me. This forces me to have to put `lintOptions {
abortOnError false
}` in the `android` options of `app/build.gradle` to be able to build and install the app. Can these issues be fixed or should this workaround be added to source?

### Steps to reproduce
1. Clone repo
2. Open it in Android Studio
3. Set up stuff
4. Try to run

### Expected behaviour
I should be able to build the project without having to do a workaround.

### Actual behaviour
I have to do a workaround so I can build the project.

## System Configuration
- Device: pop!os latest

## Screenshots

html file of errors included as .txt file (to make github happy)
[lint-results.txt](https://github.com/lbryio/lbry-android/files/5684054/lint-results.txt)

### Acceptance Criteria
1. Workaround added to source OR linting errors fixed

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the build in Android Studio and inspect the reported findings in lint-results.txt. Review app/build.gradle and determine whether the listed lint errors can be fixed; done means the project builds without the workaround, or the workaround is added to the source as specified by the acceptance criteria.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, java
Domain
build-system, mobile
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.