lbryio / lbryio/lbry-android

handle comment replies

Open
#1,011 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

type: new feature
Dominant language
Java
Stars
2.4k
Forks
110
PR merge metrics
No merged PRs in 30d

Description

comment reply format:

{
  "success": true,
  "error": null,
  "data": [
    {
      "id": 298637,
      "user_id": 1348310,
      "type": "",
      "notification_rule": "comment",
      "notification_parameters": {
        "email": {
          "email": "",
          "prefix": "",
          "subject": "",
          "placeholders": null,
          "email_template": ""
        },
        "device": {
          "name": "",
          "text": "wassuppppppp",
          "type": "comment",
          "title": "@thomas.zarebczan replied to a comment on Test",
          "target": "lbry://img#4ef28d4b8fefa9e7fb37a078226d1749b08c2359",
          "image_url": "",
          "is_data_only": true,
          "placeholders": null,
          "analytics_label": "comment"
        },
        "dynamic": {
          "hash": "1177bc39d09f1ab8c50596278d85f32236161d014018bc35ff04018e7071436a",
          "comment": "wassuppppppp",
          "parent_id": "dcacdc8513186415642a9ce4c3c229c15b8b6ab8c0f5014cf1dc7d4b97332d24",
          "claim_title": "Test",
          "comment_author": "lbry://@thomas.zarebczan#cb7ea953be131d156a780ff400414a187123e589"
        }
      },
      "is_app_readable": true,
      "is_read": true,
      "is_emailed": true,
      "is_device_notified": false,
      "active_at": "2020-09-15T21:44:49Z",
      "created_at": "2020-09-15T21:44:49Z",
      "updated_at": "2020-09-15T21:44:54Z",
      "is_seen": true
    },

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue provides a sample notification JSON response for a comment reply but names no source files, tests, or entry points. Start by locating the code that handles comment notifications and compare its behavior with the provided reply format. Done should mean comment replies are handled correctly and covered by an appropriate test.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, java
Domain
mobile
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.