Dead code pertaining to "any_languages" query generation
@shyba is already working on this.
Since May 18, 2022.
- Dominant language
- Python
- Stars
- 15
- Forks
- 16
- PR merge metrics
- No merged PRs in 30d
Description
Saw this while investigating https://github.com/lbryio/lbry-sdk/issues/3328 and any_languages search term implementation.
1 File:
https://github.com/lbryio/scribe/blob/baf630dfa7854dd6ec4152ffdf35b13999093cde/scribe/elasticsearch/search.py#L404
...contains duplicate elif cases pertaining to any_languages:
```
elif key == 'any_languages':
query['must'].append({"terms": {'languages': clean_tags(value)}})
elif key == 'any_languages':
query['must'].append({"terms": {'languages': value}})
```
Can't say which one is the correct behavior.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.