lbryio / lbryio/hub

Herald needs to accept ipv6 ping and reply with an ipv6 pong

Open
#117 0 comments 0 reactions 1 assignee View on GitHub

@moodyjon is already working on this.

Since Dec 22, 2022.

area: herald new feature
Dominant language
Python
Stars
15
Forks
16
PR merge metrics
No merged PRs in 30d

Description

While working on: https://github.com/lbryio/lbry-sdk/issues/3630

I discovered that herald ping/pong packets play a key role in letting lbry-sdk determine the "external IP". Herald needs to accept ipv6 ping and reply with an ipv6 pong containing the client's ipv6 address.

For testing purposes, it's sufficient to use ::1 (localhost), but to really deploy this we will need the external IP address.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.