layer5io / layer5io/sistent

Create `Welcome` card to test against Sistent

Open
#608 2 comments 0 reactions 1 assignee View on GitHub

@nebula-aac is already working on this.

Since Oct 25, 2024.

follow-up kind/enhancement
Dominant language
TypeScript
Stars
137
Forks
239
Avg merge
4d 14h
Merged PRs (30d)
5

Description

Current Behavior

Testing Sistent Theme Provider against some of the pages and components being used in Meshery Cloud UI.

Screenshot from 2024-05-04 22-09-34

The icons are wrapped with IconButton and the icons have been refactored to use a test base icon that describes how all icons could be. The margin right for the the second item still needs to be adjusted because it is dependent on the size of the icon and the size from the IconButton

Here is the mobile version:

image

I am testing dark mode, but needs more testing before showing the dark mode version of this.

Desired Behavior

Here is a picture of a before and after, of what it could look like, but it is not a final implementation.

Implementation
Acceptance Tests
Mockups

Contributor Guide

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.