Refactor icons to not use `React.FC`
Open
@nebula-aac is already working on this.
Since Apr 26, 2024.
kind/enhancement
v0.16.0-planning
- Dominant language
- TypeScript
- Stars
- 137
- Forks
- 239
- Avg merge
- 4d 14h
- Merged PRs (30d)
- 5
Description
See previous open issue here: https://github.com/layer5io/sistent/issues/224
Needed to open another ticket to track towards making this change for v0.16.0.
React has changes it type definitions which means React.FC will no longer be available to use.
- Update each of the icons to use the appropriate props
- [ ] Consider usingSvgIconfrom@mui/materialas it has other properties we can benefit from using - Widen the
IconPropsto acceptsxprops from MUI in order to utilize the theme object inline
- 🎨 Wireframes and designs for Layer5 site in Figma (open invite)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.