laststance / laststance/gitbox
Race on rapid combobox open/close (org/repo data hooks)
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 5
- Forks
- 2
- Avg merge
- 6h 9m
- Merged PRs (30d)
- 2
Description
Summary
useOrganizationData and useRepositoryData lack AbortController and a cancelled flag.
Source
P2 follow-up from /ship adversarial review of PR #176 (silent GitHub token refresh).
Details
Out-of-order resolution from rapid open→close→open can land stale data into the combobox state.
Fix
Add an ignore flag in the effect closure (or AbortController).
Acceptance
- Rapid open/close does not show stale data
- Tests cover the cancellation path
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the useOrganizationData and useRepositoryData hooks, then trace how their results populate the combobox during rapid open/close cycles. Add coverage for the cancellation path and verify that rapid open/close does not display stale data.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend, testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100