lasp / lasp/cdflib

DELTA_PLUS_VAR/DELTA_MINUS_VAR for support_data?

Open
#331 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
92
Forks
47
PR merge metrics
No merged PRs in 30d

Description

Currently, we assume that DELTA_PLUS_VAR and DELTA_MINUS_VAR are attached to "data" variables. This is specified in the ISTP compliance page:

https://spdf.gsfc.nasa.gov/istp_guide/vattributes.html

So right now if these uncertainty variables are attached to a support_data, it throws the error message in _verify_dimension_sizes(created_data_vars, created_coord_vars), when it has the delta variable in the create_data_variables, and then throws an error saying that the dimensions are all wrong because it is expecting that an "epoch" dimension is present.

So we either need to verify that indeed uncertainty can only be attached to data rather than support_data, in which case we should make the error message more obvious, or we should set the uncertainty variable to be the same data type as the parent data type, and make sure doing that doesn't break anything.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at _verify_dimension_sizes(created_data_vars, created_coord_vars) and compare its handling of DELTA_PLUS_VAR and DELTA_MINUS_VAR with the ISTP compliance guidance linked in the issue. Determine whether uncertainty variables may belong to support_data, then trace the data-type and dimension validation path. Done means the supported relationship is handled consistently or the resulting error clearly identifies the restriction, with regression coverage for the case.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.