larksuite / larksuite/oapi-sdk-python
Response does not close after use
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 559
- Forks
- 102
- PR merge metrics
- No merged PRs in 30d
Description
As above, there should have a corresponding close call at https://github.com/larksuite/oapi-sdk-python/blob/4274991a0c112f5b8e5d99d798e3bcd5b2b748e3/src/larksuiteoapi/api/request/request.py#L291.
This bug would cause exception if we have many requests in a short range of time.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect src/larksuiteoapi/api/request/request.py around lines 280-300, especially line 291, and trace how the response is handled after a request. Add the corresponding close call described in the issue, then verify that repeated requests no longer exhaust available resources.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- api
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100