Make pressure/density lookups consistent
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 39
- Forks
- 22
- Avg merge
- 10h 22m
- Merged PRs (30d)
- 3
Description
We're currently missing explicit pressure-density lookups in the code. These are useful for initializing a material to be in mechanical equilibrium with its surroundings (i.e. same pressure) but where the mass of the material is important so that the density needs to be specified.
I think for most EOS this wouldn't be too hard to implement and just requires some time and work. Some EOS already have this implemented in FillEOS. Other EOS do not have the proper logic in FillEOS to do these lookups and will result in unexpected behavior.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the EOS implementations and their FillEOS logic, then compare which pressure-density lookups are already supported and which produce unexpected behavior. Define consistent lookup behavior across the EOS implementations and verify that pressure-based initialization preserves the specified density and mass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- hpc
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100