use consistent forwarding in constructors for PTESolver classes
Open
Nobody has claimed this yet.
clean-up
good first issue
- Dominant language
- C++
- Stars
- 39
- Forks
- 22
- Avg merge
- 10h 22m
- Merged PRs (30d)
- 3
Description
The PTESolverBase class takes const references to indexers, but the derived classes all use forwarding references but NOT perfect forwarding. A choice should be made here and the solvers should be made consistent.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare the PTESolverBase constructor with the derived PTESolver class constructors to identify the differing reference and forwarding conventions. Decide on one consistent approach, apply it across the solver constructors, and verify that their indexer handling remains consistent.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- hpc
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100