lanl / lanl/singularity-eos

Address warnings in analytic tests from the Mie Gruneisen Us-up EOS

Open
#565 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug good first issue Testing
Dominant language
C++
Stars
39
Forks
22
Avg merge
10h 22m
Merged PRs (30d)
3

Description

When running eos_analytic_unit_tests, a lot of warnings related to the Mie-Gruneisen Us-up appear regarding negative temperature and negative entropy. Actually, the negative entropy doesn't matter because the EOS doesn't satisfy the third law of thermodynamics. In particular, $T \to 0$ corresponds to $S \to -\infty$. But the negative temperature is something that should be addressed.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running eos_analytic_unit_tests and tracing the warnings to the Mie-Gruneisen Us-up EOS cases. Determine how negative temperatures arise and what handling is expected, while treating negative entropy as acceptable per the issue; done means the negative-temperature warnings are addressed and the analytic tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
testing-qa
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.