lanl / lanl/singularity-eos

Utilize CTAD in the code more widely

Open
#554 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

clean-up good first issue
Dominant language
C++
Stars
39
Forks
22
Avg merge
10h 22m
Merged PRs (30d)
3

Description

We have some pretty gross types that we have to initialize in places, especially when it comes to the PTE solvers.

Instead of explicitly declaring these types, it may be more useful to implement CTAD in various places so that the class template can be automatically deduced from the constructor arguments.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named. Start by locating the PTE solver implementations and reviewing the template constructors and current explicit type declarations; done means identifying suitable places across the codebase where CTAD can replace those declarations and confirming the project still builds and tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
hpc
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.