Should the PTE solvers do something sensible for N=1 systems?
Open
Nobody has claimed this yet.
clean-up
- Dominant language
- C++
- Stars
- 39
- Forks
- 22
- Avg merge
- 10h 22m
- Merged PRs (30d)
- 3
Description
This is a twofold question:
- If I invoke the PTE solver for a pure cell, should it do something sensible? Should it just return?
- If we create a reduced system for, e.g., the fixed T solver with only 2 materials, we could end up with a 1x1 matrix. We should probably do something sensible there.
Thanks @dholladay00 for pointing this out
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the PTE solver and the fixed-T reduced-system path, then trace how pure-cell cases and 1x1 matrices are currently handled. Clarify the intended behavior for both cases with maintainers, and add regression coverage showing that each case behaves sensibly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100