lanl / lanl/singularity-eos

Add extrapolation to rho = 0 for spiner tables

Open
#541 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement good first issue help wanted
Dominant language
C++
Stars
39
Forks
22
Avg merge
10h 22m
Merged PRs (30d)
3

Description

Right now spiner's logarithmic interpolation means that it can never extrapolate to exactly rho = 0. An easy fix would be to check if rho < the minimum density on the table, and if it is compute pressure as
$P(rho, T) = \rho \Gamma(\rho_m, T)$
where here $\rho_m$ is the minimum density and $\Gamma$ is the Gruneisen coefficient. And one could do a similar thing for temperature.

Thanks @jhp-lanl for reminding me of this issue.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate spiner's logarithmic table interpolation and inspect how minimum density and temperature bounds are handled. Implement the requested extrapolation behavior for density and the analogous temperature case, then verify that pressure reaches rho = 0 consistently with the stated formula.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.