lanl / lanl/singularity-eos

Add explicit file and material ID checking to `spinerEOS`

Open
#516 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

good first issue Robustness
Dominant language
C++
Stars
39
Forks
22
Avg merge
10h 22m
Merged PRs (30d)
3

Description

Currently, we rely on HDF error messages for missing files or materials, but these can be rather cryptic. We should probably test for the existence of the file and the existence of a material in the SP5 file ourselves to make the error messages cleaner.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the spinerEOS entry point and reviewing how it currently opens an HDF SP5 file and looks up materials. Reproduce missing-file and missing-material cases, then define completion as clear, explicit errors for both conditions rather than cryptic HDF messages.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.