lanl / lanl/singularity-eos

EOS copies impacting performance with small array calls

Open
#508 17 comments 0 reactions 1 assignee View on GitHub

@Yurlungur is already working on this.

Since May 27, 2025.

  • #509 by @Yurlungur — merged
  • #511 by @Yurlungur — open
interface Performance
Dominant language
C++
Stars
39
Forks
22
Avg merge
10h 22m
Merged PRs (30d)
3

Description

I’m seeing a performance issue when calling the EOS routines on many small arrays (≈8 elements each). Profiling shows that every call to

my_eos.InternalEnergyFromDensityTemperature(density, temperature)

invokes the EOS copy constructor. Since the SpinerEOS object is about 20 KB (per sizeof), these repeated copies add significant overhead. It appears that PR #106 introduced an explicit copy in this path.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.