lanl / lanl/singularity-eos

`SpinerEOSDependsRhoSie` doesn't have the same cold curve infrastructure that `SpinerEOSDependsRhoT` does

Open
#474 0 comments 1 reaction 2 assignees View on GitHub

@jonahm-LANL is already working on this.

Since Mar 3, 2025.

Dominant language
C++
Stars
39
Forks
22
Avg merge
10h 22m
Merged PRs (30d)
3

Description

@jonahm-LANL It looks like SpinerEOSDependsRhoSie doesn't have the same cold curve infrastructure that SpinerEOSDependsRhoT does so I left that function disabled. It's probably faster for you to add the required functionality than it is for me.

Sounds good. I'll add it in a subsequent MR.

This is ready for final review (really just the test was added, but there are a few more changes)

Originally posted by @Yurlungur in https://github.com/lanl/singularity-eos/issues/375#issuecomment-2691556569

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.