thread lambdas through the get_sg_eos code
Open
Nobody has claimed this yet.
bug
clean-up
enhancement
- Dominant language
- C++
- Stars
- 39
- Forks
- 22
- Avg merge
- 10h 22m
- Merged PRs (30d)
- 3
Description
The get_sg_eos code currently does not have the ability to thread lambdas through. For things like partial ionization this will be required. Also, in get_sg_eos_rho_p, @dholladay00 pointed out that in in this case cache[0] may not be properly indexed for the case where nmat != npte.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the get_sg_eos and get_sg_eos_rho_p entry points described in the issue, including how cache[0] is indexed when nmat differs from npte. The work is done when lambdas can be threaded through for partial-ionization use cases and the indexing case is handled correctly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100