regula_falsi solver does not respect regions of validity
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 39
- Forks
- 22
- Avg merge
- 10h 22m
- Merged PRs (30d)
- 3
Description
I discovered in #449 that the regula_falsi solver does not respect the bounds of the equation of state. This isn't a problem for equations of state that are robust against out-of-bounds calls. However several of the analytic equations of state are quite brittle. In those cases, it is better to use the original findRoot method I wrote. We may wish to make regula_falsi more robust at some point.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the #449 reproduction and compare the regula_falsi entry point with the original findRoot method. Check how each handles equation-of-state bounds, especially for brittle analytic equations of state; done means regula_falsi no longer makes out-of-bounds calls or otherwise violates those validity regions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- hpc
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 32/100