Some introspection about molecular structure
Open
@Yurlungur is already working on this.
Since Dec 5, 2024.
enhancement
good first issue
help wanted
- Dominant language
- C++
- Stars
- 39
- Forks
- 22
- Avg merge
- 10h 22m
- Merged PRs (30d)
- 3
Description
In his review of #439, @pdmullen pointed out that it would be nice to initialize an ideal gas with, e.g.,
IdealGas(Real gm1, MeanAtomicProperties prop)
and compute Cv automatically from that. But this would require knowledge of, e.g., the mean molecular weight $\mu$, rather than the mean atomic mass.
This may also be relevant for more detailed 3T models. We should consider a strategy to enable this down the line. Perhaps, for example, by storing the number of atoms in a molecule in the MeanAtomicProperties struct, or by passing this in to the ideal gas constructor.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.