Create generic PTE state check
Open
@jhp-lanl is already working on this.
Since Jul 11, 2024.
enhancement
interface
Robustness
- Dominant language
- C++
- Stars
- 39
- Forks
- 22
- Avg merge
- 10h 22m
- Merged PRs (30d)
- 3
Description
I recently created checks in the get_sg_eos interface to look for bad values coming from the PTE solver (https://github.com/lanl/singularity-eos/pull/382). However, it would make sense to move some of these instead into a generic function that can be used outside of the get_sg_eos interface.
These checks would look for bad values as well as unphysical states (negative densities/volume fractions).
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.