Make mass fraction cutoff a function argument
Open
@jhp-lanl is already working on this.
Since Jun 19, 2024.
interface
Robustness
- Dominant language
- C++
- Stars
- 39
- Forks
- 22
- Avg merge
- 10h 22m
- Merged PRs (30d)
- 3
Description
The mass fraction cutoff for the PTE solver in the get_sg_eos_* interface should be an argument that can be passed by the calling function.
The cutoff is currently a magic number in the init_functor() for the various function calls:
https://github.com/lanl/singularity-eos/blob/909b83f8424a21d47c57b468c3867bc86ce95ad9/singularity-eos/eos/get_sg_eos_functors.hpp#L75
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.