lanl / lanl/singularity-eos

Use EOSPAC value for bulk modulus in spiner

Open
#371 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
39
Forks
22
Avg merge
10h 22m
Merged PRs (30d)
3

Description

As discussed in #370, the fact that spiner EOS uses the derivative from eospac and then constructs its own is a bit weird. We should make this a runtime option but use the value provided but eospac by default.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read issue #370 first, then locate the spiner EOS implementation and its existing use of the EOSPAC derivative. Define the runtime option so the EOSPAC bulk-modulus value is the default, and verify that the alternate constructed value remains selectable.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
hpc
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.