lanl / lanl/singularity-eos

Add PTE interface where `rho_bar` is specified directly

Open
#360 0 comments 0 reactions 1 assignee View on GitHub

@jhp-lanl is already working on this.

Since Apr 16, 2024.

enhancement
Dominant language
C++
Stars
39
Forks
22
Avg merge
10h 22m
Merged PRs (30d)
3

Description

@aematts has a good suggestion to specify rho_bar directly in the PTE solver as an input and then have the volume fractions function purely as an initial guess. Currently with specifying rho and vfrac, there is a confusing consistency condition that must be satisfied between the two.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.