lanl / lanl/singularity-eos

Deal with compressibility limit in new Gruneisen EOS

Open
#332 2 comments 1 reaction 4 assignees View on GitHub

@Yurlungur is already working on this.

Since Jan 4, 2024.

discussion enhancement Robustness
Dominant language
C++
Stars
39
Forks
22
Avg merge
10h 22m
Merged PRs (30d)
3

Description

From https://github.com/lanl/singularity-eos/pull/331 :

I think it would be good to compute a maximum density for this EOS to ensure that sound speeds aren't imaginary.

You can see we used this approach in the other Gruneisen EOS, but with a much more complicated procedure for calculating the maximum density (since it's a cubic Us-up fit).

I would recommend mirroring this approach where the user is allowed to provide a maximum density or not. If the maximum density is used, then we set it and perhaps warn the user if it's greater than the singularity in the denominator of the Hugoniot expression. If the user does not provide a maximum density, then we provide one based off of the Hugoniot fit parameter.

See this section of the other Gruneisen EOS for an example of how to do this.
https://github.com/lanl/singularity-eos/blob/f7df74f90d53e97d048cd230eec1d6203d7c37d2/singularity-eos/eos/eos_gruneisen.hpp#L40

Originally posted by @jhp-lanl in https://github.com/lanl/singularity-eos/pull/331#pullrequestreview-1802811493

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.