lanl / lanl/singularity-eos

Add feature to automatically set reference energy for Davis Products EOS

Open
#260 4 comments 1 reaction 1 assignee View on GitHub

@jhp-lanl is already working on this.

Since May 22, 2023.

enhancement good first issue
Dominant language
C++
Stars
39
Forks
22
Avg merge
10h 22m
Merged PRs (30d)
3

Description

The Davis Products EOS is most often used in combination with a reactants EOS to model reactive flows. For a detonation wave to be self-propagating, the Rayleigh line extending from the initial conditions of the reactants needs to be tangent to the release isentrope of the products at the CJ point. Most often, we want this CJ isentrope to the reference isentrope for the Davis EOS, so it makes sense to be able to automatically set the reference energy of the products EOS automatically in order to achieve this tangency condition.

This will require an iterative procedure at setup that will could look something like this:

  1. Find bounding points on the reference isentrope where the slope of the Rayleigh line is larger than and smaller than the slope of the isentrope.
  2. Use a bounded root finding method to iteratively find the point where the slope of the Rayleigh line equals the slope of the reference isentrope
  3. Calculate the energy of the CJ point given the Rayleigh line and then subtract the energy of the reference isentrope at the CJ point to calculate the appropriate energy offset.

This procedure should be done with an arbitrary reactants reference energy.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.