lanl / lanl/singularity-eos

Unify behavior of DensityEnergyFromPressureTemperature

Open
#199 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

clean-up
Dominant language
C++
Stars
39
Forks
22
Avg merge
10h 22m
Merged PRs (30d)
3

Description

This function is unused and just for convenience. It also may hinder future development for multiphase and we should remove it.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Search the repository for DensityEnergyFromPressureTemperature and inspect whether any callers or related tests remain. Remove the unused convenience function only after confirming its references, then run the available project tests to verify the build and behavior remain intact.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.