What do we do about unphysical data?
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 39
- Forks
- 22
- Avg merge
- 10h 22m
- Merged PRs (30d)
- 3
Description
This mainly applies to sesame data, but it's possible for other EOS to produce garbage states as well (see the Gruneisen EOS before I made significant modifications to protect against bad inputs).
We can do a number of different things, but they all tend to either be modifications to the result at the EOS level or some sort of production hardening layer that is applied to the EOS. My argument in favor of shifting these to a production hardening layer is that it allows the EOS to return whatever it is designed to return and nothing more. If a user wants the raw data, they can get the raw data. But if a user wants to avoid bad data (negative bulk modulus, negative heat capacity, negative temperatures, etc.) they can apply a modifier that, as the name implies, modifies the EOS output so that it is constrained to logical bounds.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing how the Sesame EOS and Gruneisen EOS handle invalid states, including the existing protections mentioned in the issue. Determine whether a production hardening layer is the chosen approach and define its constraints, affected EOS outputs, and validation criteria; the issue does not name files or tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- hpc
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100