Select FP precision at build-time
Open
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 39
- Forks
- 22
- Avg merge
- 10h 22m
- Merged PRs (30d)
- 3
Description
There is sufficient infrastructure is in place to compile a library that stores reals of arbitrary size, but this capability is not yet available downstream.
ports-of-callshould control this, but as near as I can determine this isn't available as a provided build option in that code. (There is a compile option, but this isn't available in the cmake interface or exported to downstream codes)- eye-balling some snippets there is still some "loose" FP typing, e.g. https://github.com/lanl/singularity-eos/blob/ffda4d1a0d3a63c51c365c5945db588ba97baafc/singularity-eos/eos/singularity_eos.cpp#L431 . If using an explicit FP type is unavoidable, it's worth asking if
singularity-eosshould be responsible for explicitly casting to it
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting the ports-of-call build option and how it is exposed through the CMake interface and downstream exports. Then review the loose floating-point typing in singularity-eos.cpp around line 431. Done means the selected precision is available to downstream builds and the responsibility for any required explicit casts is established.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cmake, cpp
- Domain
- build-system
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100