lanl / lanl/singularity-eos

Standardize `FillEos`

Open
#135 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
C++
Stars
39
Forks
22
Avg merge
10h 22m
Merged PRs (30d)
3

Description

The behavior of FillEos varies across EOS. A good strategy for standardizing this would be to put a general implementation in the base class and use specialized implementations only when needed.

There might be a way to overload the function to take into account some of these specialized needs though.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate all FillEos implementations and the EOS base class, then compare how their behavior differs across EOS. Define the shared behavior that can live in the base class, identify the specialized cases that must remain, and consider how the function interface should support them; the work is done when FillEos behavior is standardized without losing required specialization.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.