lanl / lanl/singularity-eos

Sanitize EOS parameters

Open
#131 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement good first issue
Dominant language
C++
Stars
39
Forks
22
Avg merge
10h 22m
Merged PRs (30d)
3

Description

There are currently few, if any, checks to make sure that NaN values aren't passed as parameters to the EOS. We should do some across the board checking of parameters.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the EOS parameter entry points and checking how inputs are currently validated for NaN values. Trace the parameter paths across the EOS implementations, then add coverage showing that invalid NaN parameters are rejected consistently. Done means the across-the-board checks are in place and the relevant validation tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.