Modifiers probably have to overload all the base class functions
Open
Nobody has claimed this yet.
bug
enhancement
- Dominant language
- C++
- Stars
- 39
- Forks
- 22
- Avg merge
- 10h 22m
- Merged PRs (30d)
- 3
Description
Mainly because they need to call the versions of the class they're modifying. i.e., shifted eos should leverage eospac's vector call, not do a blind for loop. This will require some thought to do right, but I want to make an issue to remind us about this.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the modifier classes and the base-class function interfaces. Compare shifted EOS behavior with the EOSPAC vector-call path, then determine which base functions modifiers must overload; done means modified classes delegate to the corresponding underlying vector operations rather than using blind loops.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend-api-design, performance
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100