dims[0] not the number of rows
Open
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 35
- Forks
- 17
- Avg merge
- 3m
- Merged PRs (30d)
- 1
Description
The DRaggedRightArrayKokkos type uses the dims_[0] = strides_array.size(); The comment in MATAR is wrong for defining dims_[0]. For clarity of reading, a better approach is:
dims_[0] = strides_array.dims(0);
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the DRaggedRightArrayKokkos type and inspect the assignment that initializes dims_[0]. Compare it with strides_array.dims(0), then build the project or run its available checks to confirm the dimension reports the number of rows and that existing behavior is preserved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- data
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100