lanl / lanl/ALF

Memory leak in tools.parsl_task_queue.task_list

Open Beginner friendly
#37 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
47
Forks
19
Avg merge
16d 1h
Merged PRs (30d)
1

Description

The get_task_results method only removes tasks from self.task_list if they are 'exec_done' or 'failed'.
Parsl defines a lot of other task states.
Those other ones won't get deleted from self.task_list, leaking both the Future objects and any associated resources.

https://github.com/lanl/ALF/blob/f7532fddbc399d9e0df837a4c33c4dccf76ba35a/alframework/tools/tools.py#L257-L264

This will also throw off the count in get_queued_number.

While we're at it, we can log the result when task_status == 'failed'.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in alframework/tools/tools.py around get_task_results at the linked lines, and review the Parsl task states referenced in the issue. Ensure completed task states no longer remain in self.task_list, failed results are logged, and get_queued_number reflects the remaining tasks.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
78/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.