langleyfoxall / langleyfoxall/react-dynamic-data-table

Add all supported props to prop types for the AjaxDynamicDataTable.

Open
#74 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
12
Forks
16
PR merge metrics
No merged PRs in 30d

Description

Currently in the DynamicDataTable we have all of the supported props being in the prop types object. However in the AjaxDynamicDataTable we only have a few of them with the rest being spread but not in the prop types.

I think it would be useful to add all supported props to the prop types to allow users to get type hinting when using this component.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Compare the prop types in DynamicDataTable with those in AjaxDynamicDataTable, then inspect how the latter spreads its remaining supported props. Confirm that every supported prop is represented for user type hinting, and verify the component still behaves correctly when those props are passed.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react
Domain
frontend
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.