langleyfoxall / langleyfoxall/react-dynamic-data-table
Bulk actions should pass the full rows
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 12
- Forks
- 16
- PR merge metrics
- No merged PRs in 30d
Description
Currently, the bulk actions pass an array of row.ids to the callback method. I think it would be more flexible to pass an array of all rows. This would remove the requirement for the data row to have an id property.
This would be a breaking change for any existing implementation of bulk actions.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the bulk action callback implementation and its current row.id handling. Update the behavior so callbacks receive complete rows, including rows without an id, and verify existing bulk-action behavior and the breaking-change impact on current implementations.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100