langleyfoxall / langleyfoxall/php-simple-google-maps

Add additional parameters parameter to directions method

Open
#2 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
1
Forks
2
PR merge metrics
No merged PRs in 30d

Description

The Google Directions API has optional parameters that a lot of people would probably want such as waypoints, language and traffic_mode

Perhaps users should be able to pass in an arbitrary array that will be url encoded and added to the request.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the directions method and compare its current request construction with the linked Google Directions API documentation. Determine how optional parameters such as waypoints, language, and traffic_mode should be accepted and URL-encoded. Done means arbitrary additional parameters are included in the directions request without breaking existing usage.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
api
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.