Better Healthcheck Testing/Blank database name
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1
- Forks
- 3
- PR merge metrics
- No merged PRs in 30d
Description
We just implemented a fix to handle situations where the user specifies blank dbname/username for the db config. Ex:
services:
database:
type: postgres
creds:
user: customusername
database: customdbname
The fix: https://github.com/lando/postgres/commit/893831aca236240ddeb410663a46b8d617b0d6fe
I put in a "test case" in the custom example to make sure a blank user wouldn't fail the healthcheck or otherwise create problems, however, I'm not testing blank database values. From some quick manual testing it looked like those worked ok, but would be good to explicitly test this.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the custom example and its existing healthcheck test for a blank user, then review commit 893831aca236240ddeb410663a46b8d617b0d6fe for the related fix. Add an explicit blank database case and verify that the healthcheck succeeds without creating other problems.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, postgres
- Domain
- databases, testing
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100