lando / lando/php

The error_reporting setting excludes E_DEPRECATED notices

Open
#2 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

4.x
Dominant language
Dockerfile
Stars
20
Forks
18
PR merge metrics
No merged PRs in 30d

Description

Hi,

I was wondering why the error_reporting setting is set to E_ALL & ~E_DEPRECATED (see line 42 of the local php.ini ) instead of E_ALL.

The development version of the php.ini of PHP itself sets the value error_reporting to E_ALL:

https://github.com/php/php-src/blob/PHP-7.4/php.ini-development#L484
https://github.com/php/php-src/blob/PHP-8.0/php.ini-development#L484
https://github.com/php/php-src/blob/PHP-8.1/php.ini-development#L484

Other development solutions for PHP that I am familiar with, Homebrew and Docksal, also adhere to this default.

I prefer to have this included, as it helps in finding potential deprecations early.

But maybe there is a valid reason to exclude E_DEPRECATED notices that I'm not aware of.

Thanks.

Aad

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at services/php/php.ini line 42 and compare its error_reporting value with the PHP development php.ini versions linked in the issue. Done means deciding whether to change the value from E_ALL & ~E_DEPRECATED to E_ALL, with the resulting configuration reflecting the issue's requested development default.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend
Issue type
Feature
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.