lando / lando/code-sign-action

Cannot sign/notarize a macOS app

Open
#16 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PowerShell
Stars
36
Forks
4
PR merge metrics
No merged PRs in 30d

Description

Hi,

I'm trying to use this action to sign and notarize an macOS app (my_app.app).

I use this in my workflow:

// ... build the app
      - uses: actions/upload-artifact@v4
        with:
          path: .release/my_app.app
          if-no-files-found: error
      - name: codesign app
        uses: lando/code-sign-action@v2
        with:
          file: .release/my_app.app
          certificate-data: ${{ secrets.APPLE_CERTIFICATE_DATA }}
          certificate-password: ${{ secrets.APPLE_CERTIFICATE_PASSPHRASE }}
          apple-notary-user: ${{ secrets.APPLE_NOTARIZATION_USERNAME }}
          apple-notary-password: ${{ secrets.APPLE_NOTARIZATION_PASSWORD }}
          apple-team-id: ${{ secrets.APPLE_TEAM_ID }}
          apple-product-id: com.example.my_app
          options: --options runtime

I can see that the actions/upload-artifact uploads my app correctly, but the code-sign-action reports:

/Users/runner/work/my_app/my_app/.release/my_app.app does not exist!

I guess the issue is that the macOS app is just a folder on the file system, and that this line of code only checks for files but not folders:

https://github.com/lando/code-sign-action/blob/a2d97da1cd6f31537bf59de53943c8c1acbb1eac/action.yml#L298

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at action.yml line 298, which the report identifies as checking whether the .app path exists, and compare its behavior for a macOS app bundle directory. Reproduce the workflow with .release/my_app.app and verify that the action accepts the bundle, then confirm that signing and notarization proceed without the reported missing-path error.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions, macos, powershell
Domain
ci-cd, devops, security
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.