lancedb / lancedb/lancedb

Python: Expand test suite for minimal dependency test

Open
#3,054 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
11.5k
Forks
1.1k
Avg merge
1d 15h
Merged PRs (30d)
140

Description

We run some tests without `pylance` or `pandas`, but it's pretty limited in scope. We should run most of the tests with this.

One thing we should make sure is that we only use pandas in tests that actually need pandas. For example, right now we skip `python/tests/test_table.py::test_add_pydantic_model` due to not having pandas, but that test is about pydantic, not pandas.

We should have been able to catch #3053 with this.

Contributor guide

Open the contributing guide

Research direction

Start with the minimal-dependency test configuration and python/tests/test_table.py::test_add_pydantic_model. Audit which tests are skipped because pandas is unavailable, run them without pandas where appropriate, and broaden the suite so it can catch the regression described in #3053.

Written by the indexing model from the issue text.

Assessment

Tech stack
pandas, python
Domain
testing-qa
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.