lancedb / lancedb/flight-sql-js-client

Always making insecure connections

Open
#10 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
18
Forks
4
PR merge metrics
No merged PRs in 30d

Description

https://github.com/lancedb/flight-sql-js-client/blob/decae7347da105554957edac5dc53a7f192c06dc/src/flight.ts#L137C19-L137C33

i don't know enough to update the package, i currently used an unsafe way to query the db

import_grpc_js.credentials.createSsl(null,null,null,{checkServerIdentity:false,rejectUnauthorized:false}),

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with src/flight.ts around line 137 and inspect how the client package establishes its connection. Determine why the current path requires disabling certificate and server-identity checks, then verify that the normal database-query path no longer depends on those unsafe options.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
security
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.