lance-format / lance-format/lance
bug: license-header-check.yml never runs on java-only pull requests
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 7.1k
- Forks
- 852
- Avg merge
- 3d 18h
- Merged PRs (30d)
- 272
Description
.github/workflows/license-header-check.yml runs five checks — rust/ (rs), python/ (py), protos/ (proto), java/lance-jni (rs) and java/src (java) — but its pull_request.paths filter lists only rust/**, python/** and protos/**. A pull request whose changed files are all under java/** matches none of them, so the job never runs and the two Java surfaces it checks are covered only by the post-merge push run on main.
The two Java steps arrived with #4437 without extending the filter, and the later path fixes (#4668, #4671) only updated the paths inside those steps. Adding java/** to the pull_request.paths list is a one-line change, and the Java headers are clean today, so it should not turn main red.
Steps to reproduce
- Merge a pull request whose changed files are all under
java/**. - Query the workflow runs for its head commit:
gh api "repos/lance-format/lance/actions/workflows/license-header-check.yml/runs?head_sha=<sha>" --jq .total_count
Observed 0 for #8979 (java/pom.xml), #8990 (java/lance-jni/src/transaction.rs) and #8603 (java/lance-jni/src/blocking_blob.rs). The same query returns 1 for #9106, which touches rust/lance-core/**.
Expected behavior
The job runs whenever a change touches a tree it checks, so a missing or malformed Java license header fails the pull request instead of landing on main first.
Lance version
N/A — repository CI configuration, observed at main (27daf383b).
Language binding
Java
Environment
GitHub Actions.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open .github/workflows/license-header-check.yml and inspect the pull_request.paths filter alongside the five license-header checks. Confirm the filter covers the Java tree checked by the workflow, then use the issue's GitHub Actions API query or a Java-only pull request to verify the workflow is triggered.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github-actions, java, python, rust
- Domain
- ci-cd
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Active
- Clarity
- Clearly specified
- Newbie friendliness
- 92/100