lance-format / lance-format/lance

Support of `take()` method for `LanceScanner`

Open
#9,142 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feature
Dominant language
Rust
Stars
7.1k
Forks
852
Avg merge
3d 18h
Merged PRs (30d)
272

Description

Hi Lance team
Do we have any plans to support take() method for LanceScanner? Now it does exist but the logic is not implemented.

https://github.com/lance-format/lance/blob/31d78d1707c1d2cff01ed1ab111fe9cfc58d50d8/python/python/lance/dataset.py#L7291-L7295

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in python/python/lance/dataset.py at lines 7291-7295 and inspect the existing LanceScanner.take() implementation alongside nearby scanner methods. Confirm the expected behavior from the surrounding API or maintainers, then add coverage showing that LanceScanner.take() works as intended.

Written by the indexing model from the issue text.

Assessment

Tech stack
python, rust
Domain
data-engineering
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
64/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.