lance-format / lance-format/lance

storage options does not dedupe on equivalent keys

Open
#6,447 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Rust
Stars
7.1k
Forks
852
Avg merge
3d 18h
Merged PRs (30d)
272

Description

I have local environment variables like AZURE_STORAGE_ACCOUNT_KEY, but when I supply an override with my runtime storage options, it has to use the key name azure_strorage_account_key, if I use the equivalent account_key, it would fail and still use the environment variable.

This might also be my user error in implementing how things are passed in, need to check further, just record here first.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named. Start by locating the storage-options handling and the environment-variable key normalization or deduplication path, then reproduce the Azure override case with both equivalent key names. Done means an explicit runtime option using the equivalent account_key takes precedence over the environment variable, with a regression test covering the behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
azure, rust
Domain
cloud
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.