lance-format / lance-format/lance
Remove v1 merge_insert code path
Open
Nobody has claimed this yet.
chore
- Dominant language
- Rust
- Stars
- 7.1k
- Forks
- 852
- Avg merge
- 3d 18h
- Merged PRs (30d)
- 272
Description
What to build
Once all v1 fallback cases are migrated to v2, delete the v1 code:
Mergerstruct and its methods- The v1 branch in
execute_uncommitted_impl can_use_create_plangate (all operations now use v2)- Helpers only used by v1 (e.g. parts of
create_joined_streamnot reused) - Tests specific to v1 behavior or the v1/v2 fallback logic
See milestone description for full PRD.
Acceptance criteria
-
Mergerstruct deleted -
can_use_create_planremoved - v1 branch in
execute_uncommitted_implremoved - All existing merge_insert tests pass
- No dead code remains from v1 path
Blocked by
- #6441 (DoNothing on v2)
- #6442 (partial schema on v2)
- #6444 (indexed joins on v2)
User stories addressed
- 4: single merge_insert code path
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
First review blockers #6441, #6442, and #6444, then locate the Merger struct, execute_uncommitted_impl, can_use_create_plan, and create_joined_stream. Run the existing merge_insert tests before and after the cleanup. Done means the v1-specific code and tests are removed, the listed v2 path is the only path, and all remaining merge_insert tests pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- databases
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100