lance-format / lance-format/lance
chore: use Uuid type for Transaction.uuid instead of String
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 7.1k
- Forks
- 852
- Avg merge
- 3d 18h
- Merged PRs (30d)
- 272
Description
Transaction.uuid is typed as String in lance/src/dataset/transaction.rs, but it always holds a UUID value. The proto field (pb::Transaction.uuid) is also a string.
Change Transaction.uuid to Uuid, parsing from the proto string in TryFrom<pb::Transaction> and formatting with .hyphenated() at the one callsite that builds the .txn filename. Also update TransactionBuilder::uuid to accept Uuid instead of String, which removes .to_string() calls at builder callsites that already hold a Uuid.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in lance/src/dataset/transaction.rs and trace Transaction, TryFrompb::Transaction, and TransactionBuilder::uuid. Update the conversion and builder callsites described in the issue, then check the .txn filename construction. Done means UUIDs remain typed as Uuid throughout these paths, proto strings parse correctly, and formatting uses .hyphenated().
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- database
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 76/100