lance-format / lance-format/lance
Overwrite / Restore asymmetry
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- Rust
- Stars
- 7.1k
- Forks
- 852
- Avg merge
- 3d 18h
- Merged PRs (30d)
- 272
Description
I'm not sure if this is really a problem, or more of just an observation. Overwrite and Restore seem to be very similar operations however they have slightly different conflict detection rules.
- An Overwrite operation will be blocked by an UpdateConfig operation that modifies the same keys. This seems strange. Restore does not have this callout.
- An Overwrite operation will conflict with itself. A Restore operation will not.
Can we make these the same? Or can we merge these two operations into one?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names no files, tests, or entry points. Start by locating the conflict-detection logic for Overwrite, Restore, and UpdateConfig, then compare their rules and existing tests; done means the intended relationship between these operations is decided and consistently covered.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- databases
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100