lance-format / lance-format/lance
Document primary key behavior
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 7.1k
- Forks
- 852
- Avg merge
- 3d 18h
- Merged PRs (30d)
- 272
Description
It appears we have some primary key detection logic when two Update operations execute. This attempts to detect if the two operations are potentially inserting rows with the same primary key and, if so, it will fail the operation. This behavior should be documented.
In addition, it seems we would also need to have detection logic when concurrent Append operations execute. Why don't we need this? Is this just a bug / oversight?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the Update and Append operation implementations and their primary-key conflict checks. Compare the concurrent behaviors and document the established behavior, including whether Append needs equivalent detection; done means the primary-key behavior and rationale are clearly recorded.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- documentation
- Issue type
- Documentation
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100